FIX: Remove two pane split view custom style in input system package. #2163
Conversation
|
|
|
The CI check-ptr-title is failing since the PR title isn't prefixed "FIX: " |
xianwangunity
changed the title
|
Changes so far looks good to me. Unclear why the original author applied custom style if it created I divergence from the consistent look. |
ekcoh
left a comment
ekcoh
left a comment
There was a problem hiding this comment.
Style changes makes sense to me (have not checked it in run-time). Also needs QA approval (run-time check) before landing. Thanks for correcting this!
The original default two pane split view style in uitk was not consistent with IMGUI version. As we adopt more and more windows in uitk, this inconsistence starts to show. A lot of windows have to customize their own style to override the "wrongly" default ones. |
|
Have we checked how the window looks on older Unity versions? |
|
@xianwangunity any pointers where I should look and or what to test? I don't really notice a difference in the actions editor or project wide actions editor (project settings) |
|
@Pauliusd01 The split view borders are in different colors compared with the rest of the project setting windows. Both in dark and light themes. The borders marked in red are darker compared to the green ones. |
|
@xianwangunity thanks I see it now. Looks fine on trunk but 22.3 still has a different color in the project settings, maybe an editor version ifdef is needed? (not like this is a real issue anyway but if we're fixing it then we should probably do it fully)
|
|
This change is coupled with this change in trunk (https://github.cds.internal.unity3d.com/unity/unity/pull/63644) and it was also backported to 6000.1, no further. |
I mean I'm fine with it if you are, probably not worth to try and match the look in older versions? |
I agree. Let's get this fix in asap. |
Pauliusd01
left a comment
Pauliusd01
left a comment
There was a problem hiding this comment.
There isn't a changelog entry but I don't feel like It matters, just mentioning in case someone else disagrees. Otherwise lgtm
|
@Pauliusd01 any idea why I cannot merge the branch? |
|
@xianwangunity might be due to the unsigned Contributor License Agreement but I can merge it for you if it still doesn't work after signing |
It's still blocked, please merge it in once you can, thanks a lot! |
Description
There are some custom styles here in input system package for two pane split views, which makes the input system setting window style appearing inconsistent compared with the rest of the editor windows. So in this PR, we simply removed the custom styles.
Testing status & QA
Manual testing.
Overall Product Risks
Comments to reviewers
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: